Differences

This shows you the differences between two versions of the page.

--- ochorocho_contribute_to_gitlab [2020/05/23 12:42] – [Summary] admin
+++ ochorocho_contribute_to_gitlab [2020/05/23 12:54] – [Summary] admin
@@ Line 73: / Line 73: @@
 While working on that feature i met people that were really friendly and supportive.
+===== Back to beginning =====
+I felt like we're sooooo close to get this thing merged. To be honest i thought this already for a few month. But this time i was sure. What could possibly go wrong? I had someone to review my code. Reduced the code size by ~30%, the runner built a package in 10 seconds.
+I thought i was cool at that point. Even though it was not working like packagist.com. But that was never my intention.
 ===== Summary =====
   - Read the docs ... read it again
   - Make sure people understand what feature you are developing and why you did it this way
-  - Do not intend that reviewers are experts in that field you are developing a feature for. Make them experts by providing docs and detailed answers to their questions
+  - Do not expect that reviewers are experts in that field you are developing a feature for. Make them experts by providing docs and detailed answers to their questions
   - Be a little pushy when your MR does not attract their attention by writing a message on Gitter to the community manager. Pushy does not mean being impolite!
   - Stand your ground! Don't let others make decisions. Take it as a hint and discuss it and adapt your idea/code