This shows you the differences between two versions of the page.
Both sides previous revisionPrevious revisionNext revision | Previous revisionNext revisionBoth sides next revision | ||
ochorocho_contribute_to_gitlab [2020/05/23 13:20] – [Discover Gitlab] admin | ochorocho_contribute_to_gitlab [2020/05/23 13:40] – [Luckily] admin | ||
---|---|---|---|
Line 78: | Line 78: | ||
I thought i was cool at that point. Even though it was not working like packagist.com. But that was never my intention. | I thought i was cool at that point. Even though it was not working like packagist.com. But that was never my intention. | ||
- | In the end GG was not happy about the solution building a package using the runner when the required files are already in Gitlab via the “Download Code/Tag” feature. So we agreed on starting from scratch and leave out the runner part. | + | In the end GG was not happy about the solution building a package using the runner when the required files are already in Gitlab via the “Download Code/Tag” feature. So we agreed on **starting from scratch** and leave out the runner part. |
My initial idea was correct, but at that time there was no one paying attention to that detail. | My initial idea was correct, but at that time there was no one paying attention to that detail. | ||
Line 87: | Line 87: | ||
===== Luckily ===== | ===== Luckily ===== | ||
- | In feb 2020 GG started to write proper feature issues to make sure things are done right. While i was busy living life GG rewrote the entire thing and it will hopefully be available in [[https:// | + | In feb 2020 GG started to write proper feature issues to make sure things are done right. While i was busy living life GG rewrote the entire thing and it will hopefully be available in [[https:// |
- | ]] | + | |
+ | Thanks to Mayra, Philippa and of course GG for getting this out the door. | ||
===== Summary ===== | ===== Summary ===== | ||
- | - Read the docs ... read it again | + | - Read the [[https://docs.gitlab.com/ |
- Make sure people understand what feature you are developing and why you did it this way | - Make sure people understand what feature you are developing and why you did it this way | ||
- Do not expect that reviewers are experts in that field you are developing a feature for. Make them experts by providing docs and detailed answers to their questions | - Do not expect that reviewers are experts in that field you are developing a feature for. Make them experts by providing docs and detailed answers to their questions |